search

svelteness / kit-docs

Documentation integration for SvelteKit.
https://kitdocs.vercel.app
MIT License
457 stars 32 forks source link

fix: pin create-svelte version to avoid bug like #52 #56

Closed stephane-klein closed 1 year ago

stephane-klein commented 2 years ago

See https://github.com/svelteness/kit-docs/issues/52#issuecomment-1186494202

@mihar-22 what do you think about this Pull Request, to pin create-svelte version to avoid SvelteKit breaking changes.

mihar-22 commented 2 years ago

I still don't think we should. Most the breaking changes where from the upgrade to Vite 3 which have cooled down now. I just missed the $app fix when I updated things before.

stephane-klein commented 2 years ago

I just missed the $app fix when I updated things before.

@mihar-22 I think you haven't missed $app, in your https://github.com/svelteness/kit-docs/commit/22d6a8350212c3aa2efc0b70cb29b219f16bed91 dated 2022-07-13, because the SvelteKit breaking change date 2022-07-14, after your fix :thinking:.

stephane-klein commented 2 years ago

@mihar-22 since 2 weeks, I think I have each day some breaking change. For now, I think it is not possible to use Kit-docs 😭

mihar-22 commented 1 year ago

I'm sorry @stephane-klein. I'll have a look today to see if I can get everything working again.