svelteness / kit-docs

Documentation integration for SvelteKit.
https://kitdocs.vercel.app
MIT License
457 stars 32 forks source link

migrate to latest sveltekit #69

Closed mihar-22 closed 1 year ago

mihar-22 commented 1 year ago

Continuation of the work from @slowsage and @davej:

mihar-22 commented 1 year ago

Only one issue remaining which is the Vite server keeps restarting on any file change. No idea why at the moment. I'll have to come back to it in a few days but if anyone wants to dig at it:

  1. git clone git@github.com:svelteness/kit-docs.git && cd kit-docs
  2. git checkout pr/67
  3. pnpm i
  4. pnpm dev
  5. make a change in any markdown file (try this one)
  6. observe infinite server restarts and dev server stops working

Core Vite plugin can be found here. Markdown Vite plugin can be found here.

joshnuss commented 1 year ago

@mihar-22 Updating vite to ^4.0.0 seems to fix it for me.

mihar-22 commented 1 year ago

Unforunately just tested that @joshnuss and it still fails. I'm getting the sense this might be a local only issue due to symlinks. I'm going to release and see how it goes for everyone.

MarkyEasyGo commented 1 year ago

Hey did we figure out a way past Vite server constantly refreshing and breaking local dev? Sadly I'm unable to run any combo locally, fresh installs and following instructions on docs page.

mihar-22 commented 1 year ago

Unforunately not @MarkyEasyGo, I opened a new issue.