[@svelteuidev/core] #217: fix menu open/close events not being dispatched - Githubissues

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.3k stars 62 forks source link

[@svelteuidev/core] #217: fix menu open/close events not being dispatched #245

Closed BeeMargarida closed 1 year ago

BeeMargarida commented 1 year ago

FIxes #217.

Due to the event forwarding logic, it was necessary to set the open and close events as exceptions. Probably in the future we will have to revisit the event forwarding logic.

Before submitting the PR, please make sure you do the following

[X] Read the Contributing guide
[X] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[X] This message body should clearly illustrate what problems it solves.

Tests

[X] Run the tests with npm test and lint the project with yarn lint or just run yarn repo:prepush and check to see if it's passing.