search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.3k stars 62 forks source link

Cannot set "class" on Title #265

Closed drewbitt closed 1 year ago

drewbitt commented 1 year ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

According to the FAQ, in order to integrate with Tailwind you add the "class" property. In the example, the Button class has the property. However, Title does not

image

Using className is not an alternative as it does not set "class" on the DOM element

In which browser(s) did the problem occur?

No response

Steps To Reproduce

Download 0.7.7 from the npm registry

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Relevant Assets

No response

BeeMargarida commented 1 year ago

It should be fixed now in the next patch (to come)

drewbitt commented 1 year ago

It is fixed in the next-minor branch. Thanks @BeeMargarida

drewbitt commented 1 year ago

@BeeMargarida this seems to have regressed between your patch and the release of 0.8 as the error has returned

BeeMargarida commented 1 year ago

Thank you for pointing it out, will fix it and release a new patch

BeeMargarida commented 1 year ago

I've recently merged a big PR that fixes a lot of the existing typing problems, I checked and it fixes this problem. I'm hoping to release a new minor version this week, hopefully everything goes well and this is fixed for good

BeeMargarida commented 1 year ago

This should be totally fixed in the new release 0.9.0