[@svelteui/core]: remove aria-required from NativeSelect - Githubissues

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.3k stars 62 forks source link

[@svelteui/core]: remove aria-required from NativeSelect #289

Closed BeeMargarida closed 1 year ago

BeeMargarida commented 1 year ago

This PR fixes #283.

As pointed out in the related issue, it should use only required and not aria-required.

Before submitting the PR, please make sure you do the following

[X] Read the Contributing guide
[X] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[X] This message body should clearly illustrate what problems it solves.

Tests

[X] Run the tests with npm test and lint the project with yarn lint or just run yarn repo:prepush and check to see if it's passing.