Feature/breadcrumb - Githubissues

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.3k stars 62 forks source link

Feature/breadcrumb #303

Closed mineofcode closed 1 year ago

mineofcode commented 1 year ago

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing guide
[ ] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[ ] This message body should clearly illustrate what problems it solves.

Tests

[ ] Run the tests with npm test and lint the project with yarn lint or just run yarn repo:prepush and check to see if it's passing.

mineofcode commented 1 year ago

There's commits and changes for the radio component. This branch should only contain commits and changes of the breadcumb component.

Also, why the need for a BreadcumbItem component? Couldn't that logic be included inside the Breadcumb? It seems too much for a simple component

Oops is it let me check.
I think if there is ui tags for component it will have more control for users to manipulate the dom. It should be same design pattern isn't it?