svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.3k stars 62 forks source link

color="white" or color="black" setting invalid svelteui color var in dark mode #319

Closed drewbitt closed 1 year ago

drewbitt commented 1 year ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

I have a

<Title order={2} color="white">Text here</Title>

Which is generating in dark mode

.dark-theme .svelteui-c-bQvgQt {
    color: var(--svelteui-colors-white600);
}

There is no white600; white only has one var, --svelteui-colors-white. Svelteui is attempted to dim colors without dim values.

In which browser(s) did the problem occur?

No response

Steps To Reproduce

Use a svelteui element utilizing the color attribute; specify the svelteui TextColor "white" or "black"

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Relevant Assets

No response

BeeMargarida commented 1 year ago

Forgot to link in the commit, but fixed by https://github.com/svelteuidev/svelteui/commit/b9e68b099513849e561db942b396f361e23ea1a9