[docs]: Changes to code structure and design

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.28k stars 64 forks source link

[docs]: Changes to code structure and design #338

Closed 1yne closed 1 year ago

1yne commented 1 year ago

Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] This message body should clearly illustrate what problems it solves.
[ ] Run yarn prepush:repo

Tests

[ ] Run the tests with yarn test.

BeeMargarida commented 1 year ago

Thank you for this fixes 🙌

BeeMargarida commented 1 year ago

Sorry, it's been a busy couple of weeks, I'll try to pick this up as soon as I can

1yne commented 1 year ago

I fixed two of the issues. When I checked the sidebar in the mobile, it worked perfectly. How did it look on your side?

1yne commented 1 year ago

When I changed the transition from 400 to 100, it not only changed the speed of the page sliding away but the content also zoomed in at very fast speeds which didn't give it a good look. Will 300 be fine?

1yne commented 1 year ago

BTW, I've been thinking whether I should try keeping dark theme as the default one. The ability to switch between light and dark theme still needs to be fixed but it would be better on everyone's eyes if the website came with dark theme first, not the light theme. What's your view on this?

BeeMargarida commented 1 year ago

BTW, I've been thinking whether I should try keeping dark theme as the default one. The ability to switch between light and dark theme still needs to be fixed but it would be better on everyone's eyes if the website came with dark theme first, not the light theme. What's your view on this?

Sorry for taking a while to respond. I'm actually of the opinion of leaving the light mode, since it's normally the default of the web and it's easier to read for most people (this coming from a dark mode gal). Either way, we can have this discussion again when the dark mode is fixed :sweat_smile:

BeeMargarida commented 1 year ago

I fixed two of the issues. When I checked the sidebar in the mobile, it worked perfectly. How did it look on your side?

Perfect :ok_hand:

When I changed the transition from 400 to 100, it not only changed the speed of the page sliding away but the content also zoomed in at very fast speeds which didn't give it a good look. Will 300 be fine?

Let's leave it as is for now then, we can tweak it later

BeeMargarida commented 1 year ago

I think this is ready for merge. Thank you so much for this contribution :raised_hands: :tada:

BeeMargarida commented 1 year ago

All that is left is fixing the dark theme and it should be ready!