search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.28k stars 64 forks source link

Dark theme uses wrong color in inputs #343

Closed gabrielnvian closed 1 year ago

gabrielnvian commented 1 year ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

When using dark theme, TextInput, NativeSelect (all inputs) components have black as default color (font color).

I believe the default color should be white. (As it was in 0.8.0)

In which browser(s) did the problem occur?

No response

Steps To Reproduce

<SvelteUIProvider withGlobalStyles withNormalizeCSS themeObserver="dark">
    <TextInput/>
</SvelteUIProvider>

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Relevant Assets

No response

BeeMargarida commented 1 year ago

I'll release a patch with the fix this week

gabrielnvian commented 1 year ago

@BeeMargarida disabled buttons also seem to suffer the same problem: background-color becomes white. Will that be fixed as well?

BeeMargarida commented 1 year ago

disabled buttons also seem to suffer the same problem: background-color becomes white. Will that be fixed as well?

Thank you for pointing that out, it's been fixed!

gabrielnvian commented 1 year ago

@BeeMargarida When can we expect this fixes to be rolled out?

BeeMargarida commented 1 year ago

@gabrielnvian Sorry, we want to make a release in addition with the docs port to SK, that part is basically done, so it will be very soon