[docs]: Tweaks and fixes in dark theme

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.28k stars 64 forks source link

[docs]: Tweaks and fixes in dark theme #352

Closed 1yne closed 1 year ago

1yne commented 1 year ago

Description

Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] Include a description of the changes made in the PR description and in the commit messages.
[ ] Include screenshots/videos of the changes made.
[ ] Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

There were quite a few bugs with components and this fixes it

1yne commented 1 year ago

There's another problem with the dark theme when you visit the "Dark Theme" page in the Theming section where when you visit it, even if you have dark theme enabled, it automatically switches to light mode. How should I go about fixing it?

https://user-images.githubusercontent.com/94300963/233678875-0cd1ee56-e29b-4a9a-a9ac-6eb999d92704.mov

BeeMargarida commented 1 year ago

There's another problem with the dark theme when you visit the "Dark Theme" page in the Theming section where when you visit it, even if you have dark theme enabled, it automatically switches to light mode. How should I go about fixing it?

I'm fixing that right now, it's a outdated decision in the dark theme demo. Thank you for pointing it out!

One thing, if you want to tackle it in this PR, is fixing the navigation in the search modal: when navigating from there to a component page and then to a composable page, it breaks because it builds a wrong URL, like /core/composable/use-clipboard instead of composable/use-clipboard

Update: dark theme demo is fixed

1yne commented 1 year ago

It seems to be working for me. All the links in data.ts look good as well. Which two links did you visit that broke the code?

BeeMargarida commented 1 year ago

It seems to be working for me. All the links in data.ts look good as well. Which two links did you visit that broke the code?

An example in video, since it's easier to explain:

https://user-images.githubusercontent.com/25725586/233776312-cbef0801-d1cc-476f-b86b-f1b3233727e7.mp4

1yne commented 1 year ago

This is how it looks on my side:

https://user-images.githubusercontent.com/94300963/233797150-1ae4d6f7-6316-4142-a573-5a72de7ff481.mov

BeeMargarida commented 1 year ago

Nvm, had to clean my local storage

BeeMargarida commented 1 year ago

Thank you for this contribution!! :raised_hands: