svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.28k stars 64 forks source link

There is a Button variant called 'default', which is not the default #357

Open piersg opened 1 year ago

piersg commented 1 year ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

It's a bit cosmetic and maybe this is a feature request not a bug, but it seems to me that the button variant 'default' should either in fact be the default variant, or get renamed (to something like 'normal' or 'plain').

My 2c is that 'default' should be the default variant. Coloured buttons for me suggest that they will fire when you press return/enter (ironically, the 'default' button, in another sense). But I could be in a minority there.

In which browser(s) did the problem occur?

No response

Steps To Reproduce

  1. Put a Button in your app without specifying a variant
  2. The button will not be in the variant 'default" but 'filled'

Which is as the documentation clearly states will happen, of course.

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Relevant Assets

No response

BeeMargarida commented 1 year ago

I understand your point, but by default we want to filled variant for Button, like we want hover variant for ActionIcon. Perhaps the change here is renaming the default variant instead of changing the defaults

Brisklemonade commented 1 year ago

I think a rename would be better, if things really need to be changed.