Closed 1yne closed 1 year ago
I'm gonna leave here what I wrote in the issue, since this change has more ramifications than it looks. I'm gonna close since this is not the best way of solving this, but thank you for your work!
I understand your point, but by default we want to
filled
variant for Button, like we wanthover
variant for ActionIcon. Perhaps the change here is renaming thedefault
variant instead of changing the defaults
Description
Before submitting the PR, please make sure you do the following
[@svelteui/core]
,[@svelteui/actions]
,[@svelteui/motion]
,[@svelteui/core]
,[core]
, or[docs]
.yarn lint
andyarn test
or just runyarn prepush
.The current button uses the
filled
variant when the variant prop is not given. As pointed by @piersg in #357, it should instead use thedefault
variant