search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.28k stars 64 forks source link

[Feature Request] Select component #359

Open BeeMargarida opened 1 year ago

BeeMargarida commented 1 year ago

Usage example, including component, action, motion, or utility API

Implement a Select component that allows customization of the items inside it

Possible implementation - describe how the feature can be implemented

No response

Do you want to contribute this feature and create a pull request

Yes

DaniAcu commented 1 year ago

@BeeMargarida Can I take this?

BeeMargarida commented 1 year ago

@BeeMargarida Can I take this?

Yap, feel free to tackle this! Do you want me to assign this to you? As a heads up, we follow the design system of Mantine, so you can base the styling on their component. Any question you have, I'm around here or in Discord

DaniAcu commented 1 year ago

I saw a feature branch that is working on this. Idk the status of that branch. Do you want that I continue with that work or start from scratch?

In any case I will start working in the accordion for now, so i you could assing me to that, happy to help 😃

BeeMargarida commented 1 year ago

That branch has some work started, but it's outdated, not sure it's worth basing upon. Let me know if you still want to work on this or the Accordion

DaniAcu commented 1 year ago

Okay, perfect. Let me start with Select then.

Thanks for all the extra info 😉

BeeMargarida commented 1 year ago

Got it, assigned! Let me know if you need any help! 😄

BeeMargarida commented 1 year ago

@DaniAcu Hi! Any update? Do you need any help?

DaniAcu commented 1 year ago

Sorry I had troubles with internet and pc last weeks, so I didnt do too much. I read the docs and checking Mantine. I would like to know about the expected API that we would like to have.

Matine have only props:


<Select data=[...options] />

I was thinking in something more similar to html

<Select>
  <Option></Option>
  <Option></Option>
  <Option></Option>
</Select>

We prefer mantain the same approuch of Mantine or we could create a different abstractions?

BeeMargarida commented 1 year ago

Sorry I had troubles with internet and pc last weeks, so I didnt do too much. I read the docs and checking Mantine. I would like to know about the expected API that we would like to have. We prefer mantain the same approuch of Mantine or we could create a different abstractions?

No problem! Regarding the API, I would go with something similar to HTML, since that's the philosophy of Svelte. It's not necessary to have the same API has mantine, only the design system. However, if you find any problems or challenges with that approach, we can discuss it.