search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.28k stars 64 forks source link

[Feature Request] `strikeThrough` property for `Text` #375

Open notramo opened 1 year ago

notramo commented 1 year ago

Usage example, including component, action, motion, or utility API

Please add a property for the Text component to make it strike-through.

Possible implementation - describe how the feature can be implemented

No response

Do you want to contribute this feature and create a pull request

Yes

BeeMargarida commented 1 year ago

This is already possible with something like 

<Text override={{ textDecoration: 'line-through' }}>This is a nice text</Text>

Do you mean having this as a prop that applies this style? I'm not sure it scales, since we will have to also add props for the other text decorations

notramo commented 1 year ago

@BeeMargarida, Text is already styled with properties. What aspects of styling are used in deciding if it should be a prop or not?

BeeMargarida commented 1 year ago

@BeeMargarida, Text is already styled with properties. What aspects of styling are used in deciding if it should be a prop or not?

Yap, you're right, we already have underline. Sure, we can add a prop for strikethrough, but I would call it lineThrough, to match the css property. Do you wish to contribute with this feature?

notramo commented 1 year ago

@BeeMargarida, I can try to implement this, you can assign it to me.

BeeMargarida commented 1 year ago

@BeeMargarida, I can try to implement this, you can assign it to me.

If you need any help or have any questions, feel free to ask me here or in Discord

BeeMargarida commented 1 year ago

Hi, any update? Do you need any help?

notramo commented 1 year ago

I need to get familiar with the codebase a little bit more, and I haven't found time for it yet. However, it doesn't seem to be a difficult task.