search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.28k stars 64 forks source link

`ActionIcon` not respecting dark theme since 0.12.0 #384

Closed notramo closed 1 year ago

notramo commented 1 year ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

ActionIcon component uses the same colors with dark theme as the light theme. Tested variants: filled (looks bad), default (looks terrible), outline (kind of OK).

In which browser(s) did the problem occur?

No response

Steps To Reproduce

Use dark theme with SvelteUI 0.12.0 or 0.12.1.

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Relevant Assets

No response

BeeMargarida commented 1 year ago

Can you include screenshots/videos?

notramo commented 1 year ago

image

notramo commented 1 year ago

For comparison, here is the previous version (0.11.1) of the same ActionIcon: image

BeeMargarida commented 1 year ago

Got it, it's definitely a regression. I think I know what caused it, will fix it today as well

BeeMargarida commented 1 year ago

Also fixed by https://github.com/svelteuidev/svelteui/commit/8fd0155dd44b0f9aa964d5e05cf37cab5d761d52

BeeMargarida commented 1 year ago

Fixed in new release 0.13.0