search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.28k stars 64 forks source link

Links back to doc github pages via "Edit this page" links not working. #386

Closed KevinHodder closed 1 year ago

KevinHodder commented 1 year ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

From any given component documentation page, the "Edit this page" github link is broken, because of the move to sveltekit +page.md format

In which browser(s) did the problem occur?

No response

Steps To Reproduce

  1. Go to any given doc page e.g. this one
  2. In the header, click "Edit this page"
  3. Observe the 404

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Relevant Assets

The whole set of docs can be fixed with a regex replace, and one small string change.

replace docs: '(\w*)/([\w-]*).md' with docs: '$1/$2/+page.md'

and update /apps/docs/src/lib/components/Heading.svelte #line 11 with docs: 'https://github.com/svelteuidev/svelteui/blob/main/apps/docs/src/routes/',

Tested and confirmed working with these two changes. Tried to push a branch for your consideration, but permission denied.

BeeMargarida commented 1 year ago

Thank you for pointing this out :raised_hands:, it has been fixed and deployed