[docs]: Add transitions on expanding in Sidebar

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.28k stars 64 forks source link

[docs]: Add transitions on expanding in Sidebar #388

Closed 1yne closed 1 year ago

1yne commented 1 year ago

Description

Title

Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] Include a description of the changes made in the PR description and in the commit messages.
[ ] Include screenshots/videos of the changes made.
[ ] Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

BeeMargarida commented 1 year ago

I've been away from the computer this week, I will take a look at this tomorrow

1yne commented 1 year ago

I notice one problem with this change: when navigating to another page, the sidebar animates when opened, which creates a weird effect:

Perhaps it's best to remove the transitions in the sidebar sections for now.

Yeah, for some reason, even though there is no change to the sidebar value when we navigate through the pages, it will still rerun the transition every time. I tried using #key as well but didn't work. Guess I gotta drop that idea

BeeMargarida commented 1 year ago

Yeah, for some reason, even though there is no change to the sidebar value when we navigate through the pages, it will still rerun the transition every time. I tried using #key as well but didn't work. Guess I gotta drop that idea

Hum, did you try adding the |local modifier to the transitions? Perhaps it fixes in this case

1yne commented 1 year ago

Hum, did you try adding the |local modifier to the transitions? Perhaps it fixes in this case

Yeah, that works!

1yne commented 1 year ago

I've added the latest commit in my fork but there seems to be some issue with merging. Could you take a look at it?

BeeMargarida commented 1 year ago

I've added the latest commit in my fork but there seems to be some issue with merging. Could you take a look at it?

~~It seems like a Github issue. It happened to me in another repo as well. Don't have the solution for it yet. Hum, not sure if force pushing would fix it~~

Nvm, it's fixed. I'll take a look at the conflicts

BeeMargarida commented 1 year ago

Sorry, been busy, I'll pick it up today or tomorrow

BeeMargarida commented 1 year ago

Sorry again, I'll pick it up tomorrow for sure!

BeeMargarida commented 1 year ago

Thank you for this contribution! 🙌 And so sorry for the delay, life got a bit hectic for a while, now back to normal.