search

svelteuidev / svelteui

SvelteUI Monorepo
https://svelteui.dev
MIT License
1.27k stars 63 forks source link

[@svelteuidev/core][0.14.0] Loader numbered "size" not working #442

Closed xr0master closed 11 months ago

xr0master commented 11 months ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

If you specify the size as a number, then this value is ignored.

In which browser(s) did the problem occur?

No response

Steps To Reproduce

You can check the docs in the "Size" section the size={50} is ignored. https://www.svelteui.org/core/loader

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Relevant Assets

No response

xr0master commented 11 months ago

The fix should be easy:

size={LOADER_SIZES[size]}

switch to 

size={typeof size === 'number' ? size : LOADER_SIZES[size]}

BTW I noticed that many components have the same issue with radius prop; Like ActionIcon and so on