[@svelteui/core]: Added Table component

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.31k stars 62 forks source link

[@svelteui/core]: Added Table component #456

Closed 1yne closed 4 months ago

1yne commented 1 year ago

Description

Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] Include a description of the changes made in the PR description and in the commit messages.
[ ] Include screenshots/videos of the changes made.
[ ] Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

Adds a Table component

1yne commented 1 year ago

I'm quite new to creating components, so if there is any feedback, please do let me know

BeeMargarida commented 1 year ago

Hey! I'll check this out this week. We are kinda in a freeze of new components, since we are in the process of migrating to a new solution for our style API (stitches was deprecated). I'll try to see if this can squeeze in, but it might be put on hold until the migration is complete

1yne commented 1 year ago

Sure! I just felt that if we could finish this, we could also start with #387

1yne commented 1 year ago

I've been trying to implement the changes but this error has been popping up ever since. Any ideas?

Screenshot 2023-09-17 at 11 03 55 PM

BeeMargarida commented 1 year ago

I've been trying to implement the changes but this error has been popping up ever since. Any ideas?

Hum, I'll check it out today. But even after clean install and everything?

1yne commented 1 year ago

Yup. I deleted my local files and cloned the fork again with a clean install. Still didn't work

BeeMargarida commented 1 year ago

Yup. I deleted my local files and cloned the fork again with a clean install. Still didn't work

Hum, what version of node are you using?

1yne commented 1 year ago

Hum, what version of node are you using?

v16.18.0

BeeMargarida commented 1 year ago

Hum, what version of node are you using?

v16.18.0

I can't replicate the issue :thinking: I'm using the same node version, removed node_modules, cleaned yarn cache and reinstalled, it's working ok. I normally use node 18 or 20, but even node 16 is working fine.

1yne commented 1 year ago

Hi, any update on this? I'm still not sure on what to do

BeeMargarida commented 1 year ago

Hey, I'm currently focusing on the style API migration. I'll check this out as soon as I can. I can try to make the stories, so that I can check that everything is working properly. However, I'm still not sure what's happening in your setup, I can't replicate it on my side.

1yne commented 1 year ago

Hey, I'm currently focusing on the style API migration. I'll check this out as soon as I can. I can try to make the stories, so that I can check that everything is working properly. However, I'm still not sure what's happening in your setup, I can replicate it on my side.

Sure, thanks for looking into it!

BeeMargarida commented 1 year ago

My bad, I pushed to the wrong branch. I'll revert it.

I'll try to take a look at this next week, perhaps it can be merged.

wuleninja commented 11 months ago

Thanks for this one! Until it's ready, I'll probably go with SMUI for a POC. But I'd rather use SvelteUI once it's completed with data tables 👍

BeeMargarida commented 10 months ago

TODOs (note for me): add demos and docs