Make Radio and RadioGroup labelDirection consistent and fix label type error - Githubissues

svelteuidev / svelteui

SvelteUI Monorepo

https://svelteui.dev

MIT License

1.26k stars 62 forks source link

Make Radio and RadioGroup labelDirection consistent and fix label type error #497

Open BeeMargarida opened 2 weeks ago

BeeMargarida commented 2 weeks ago

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

The labelDirection default values for Radio and RadioGroup are different
There's an error with the label prop in RadioGroup, documented in this Discord support thread

In which browser(s) did the problem occur?

Firefox

Steps To Reproduce

Use this sample code: https://stackblitz.com/edit/sveltejs-kit-template-default-amdvqf?file=src%2Froutes%2F%2Bpage.svelte

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Relevant Assets

No response

BeeMargarida commented 4 days ago

Label type error fixed in https://github.com/svelteuidev/svelteui/commit/3abcbfd79158a4336bf9e3730ee5d88d8f5ec25c, but the change in labelDirection is a breaking change, and will probably be addressed in the next version of the lib.