sveltia / sveltia-cms

Alternative to Netlify/Decap CMS. Fast, lightweight, Git-based headless CMS. Modern UX, first-class i18n support, open source & free. Made with Svelte.
MIT License
819 stars 38 forks source link

Correction for Local Development #195

Closed syzio closed 2 weeks ago

syzio commented 2 weeks ago

Hey, can't wait for 1.0

In the mean time, I would like to point out that the check for Local Backend at https://github.com/sveltia/sveltia-cms/blob/main/src/lib/components/entrance/sign-in.svelte#L24 while correct, could use clarification in the message and/or readme - that File System Access API is available since Chrome 86, but some browsers, like Brave (what I use) require it to be enabled via a flag: image

kyoshino commented 2 weeks ago

It’s actually mentioned in the README. I’ll check if I can add Brave-specific message to the entrance page.

syzio commented 2 weeks ago

yeah that info is there, i was thinking just more like - 'showDirectoryPicker' in window || ( chrome > 86 && 'enable file system api')

kyoshino commented 2 weeks ago

A message added in v0.38.2.

Since we don’t know if all the chromium-based browsers support the File System Access API, and the way to enable it may vary by browser, it’s safe to show a message just to Brave users.

Anyway, thanks for the heads-up!