search

sven-n / MuMain

76 stars 72 forks source link

Fixed a CM exception when placing a +13 wings #53

Closed nitoygo closed 1 month ago

nitoygo commented 1 month ago

Resolves: https://github.com/sven-n/MuMain/issues/52

nitoygo commented 1 month ago

Unrelated to the bug, but similar patterns - possible bugfixes but needs to be defined as macros making the code dirty:

source\CSChaosCastle.cpp:48:#ifdef LJW_FIX_MANY_FLAG_DISAPPEARED_PROBREM
source\CGFxMainUi.cpp:1169:#ifdef PBG_FIX_ITEMANGLE
source\CGFxMainUi.cpp:1333:#ifdef PBG_FIX_ITEMANGLE
source\CGFxMainUi.cpp:1362:#ifdef PBG_FIX_ITEMANGLE
source\CGFxMainUi.cpp:2025:#ifdef PBG_FIX_ITEMANGLE
source\CGFxMainUi.cpp:2147:#ifdef LDK_FIX_CAOS_THUNDER_STAFF_ROTATION
source\CGFxMainUi.cpp:2161:#ifdef KJH_FIX_20080904_INVENTORY_ITEM_RENDER
source\CGFxMainUi.cpp:2232:#ifdef LDS_FIX_ELFHELM_CILPIDREI_RESIZE
source\CGFxMainUi.cpp:2818:#ifdef LDK_FIX_INVENTORY_SPEAR_SCALE
source\CGFxMainUi.cpp:3690:     #ifdef KJH_FIX_WOPS_K29544_SOULBARRIER_UPGRADE_TOOLTIP
source\CGFxMainUi.cpp:3840:     #ifdef PBG_FIX_SKILL_RECOVER_TOOLTIP
source\CGFxMainUi.cpp:3934:     #ifdef YDG_FIX_MASTERLEVEL_ELF_ATTACK_TOOLTIP
source\CGFxMainUi.cpp:3963:     #ifdef YDG_FIX_MASTERLEVEL_ELF_ATTACK_TOOLTIP
source\CGFxMainUi.cpp:3982:     #ifdef PBG_FIX_SKILL_RECOVER_TOOLTIP
source\CGFxMainUi.cpp:4060:     #ifdef CSK_FIX_SKILL_BLOWOFDESTRUCTION_COMBO
source\CGFxMainUi.cpp:4443:#ifdef PBG_FIX_SKILL_DEMENDCONDITION
source\CGFxMainUi.cpp:4537:#ifdef PJH_FIX_SPRIT
source\CGFxMainUi.cpp:4558:#ifdef PJH_FIX_SKILL
source\CGFxMainUi.cpp:4573:#ifdef KJH_FIX_WOPS_K20674_CHECK_STAT_USE_SKILL
source\CGFxMainUi.cpp:4577:#ifdef YDG_FIX_BLOCK_STAFF_WHEEL
source\CGFxMainUi.cpp:4590:#ifdef YDG_FIX_STAFF_FLAMESTRIKE_IN_CHAOSCASLE
source\CGFxMainUi.cpp:4604:#ifdef LDK_FIX_CHECK_STAT_USE_SKILL_PIERCING
source\CGFxMainUi.cpp:4623:#ifdef YDG_FIX_BLOCK_STAFF_WHEEL
source\CGFxMainUi.cpp:4670:#ifdef PJH_FIX_4_BUGFIX_33
source\CGFxMainUi.cpp:4984:#ifdef KJH_FIX_INGAMESHOP_INIT_BANNER
source\Event.cpp:370:#ifdef CSK_FIX_BLUELUCKYBAG_MOVECOMMAND
source\GameShop\MsgBoxIGSBuyPackageItem.h:92:#ifdef LEM_FIX_WARNINGMSG_BUYITEM
source\GameShop\MsgBoxIGSUseItemConfirm.cpp:149:#ifdef LEM_FIX_WARNINNGMSG_DELETE
source\GMEmpireGuardian2.cpp:571:#ifdef LDS_FIX_ACCESS_INDEXNUMBER_ALREADY_LOADTEXTURE
source\GMEmpireGuardian3.cpp:751:#ifdef LDS_FIX_ACCESS_INDEXNUMBER_ALREADY_LOADTEXTURE
source\GMEmpireGuardian4.cpp:789:#ifdef LDS_FIX_ACCESS_INDEXNUMBER_ALREADY_LOADTEXTURE
source\MapManager.cpp:1290:#ifdef KJH_FIX_ICARUS_MAP_ATTRIBUTE_FOR_TESTSERVER
source\NewUICommon.cpp:15:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUICommon.cpp:142:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUICommon.cpp:184:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUICommon.cpp:193:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUICommon.cpp:202:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUICommon.cpp:211:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUICommon.h:53:#ifdef ASG_FIX_ACTIVATE_APP_INPUT
source\NewUIItemEnduranceInfo.cpp:10:#ifdef PJH_FIX_SPRIT
source\NewUIItemEnduranceInfo.cpp:354:#ifdef PJH_FIX_SPRIT
source\NewUILuckyItemWnd.cpp:30:#ifdef LEM_FIX_LUCKYITEM_UICLASS_SAFEDELETE
source\NewUILuckyItemWnd.cpp:302:#ifdef LEM_FIX_LUCKYITEM_UICLASS_SAFEDELETE
source\NewUILuckyItemWnd.cpp:523:#ifdef LEM_FIX_LUCKYITEM_SLOTCHECK
source\NewUIMainFrameWindow.cpp:2176:#ifdef PJH_FIX_SPRIT
source\NewUIMyInventory.cpp:25:#ifdef CSK_FIX_BLUELUCKYBAG_MOVECOMMAND
source\NewUIMyInventory.cpp:238:#ifdef PBG_FIX_EQUIP_TWOHANDSWORD
source\NewUIMyInventory.cpp:2128:#ifdef LJH_FIX_APP_SHUTDOWN_WEQUIPPING_INVENITEM_WITH_CLICKING_MOUSELBTN
source\NewUISystem.cpp:572:#ifdef LEM_FIX_LUCKYITEM_UICLASS_SAFEDELETE
source\SocketSystem.h:112:#ifdef YDG_FIX_SOCKET_MISSING_MAGIC_POWER_BONUS
source\WSclient.cpp:12805:#ifdef LEM_FIX_SERVERMSG_SEALITEM
source\ZzzBMD.cpp:2554:#ifdef LDS_FIX_SETNULLALLOCVALUE_WHEN_BMDRELEASE
source\ZzzEffect.cpp:6755:#ifdef PJH_FIX_4_BUGFIX_7
source\ZzzEffect.cpp:6762:#ifdef PJH_FIX_4_BUGFIX_7
source\ZzzEffect.cpp:6772:#ifdef PJH_FIX_4_BUGFIX_7
source\ZzzInterface.cpp:184:#ifdef LEM_FIX_USER_LOGOUT
source\ZzzInterface.cpp:3634:#ifdef LJH_FIX_CANNOT_CLICK_BASKETS_IN_CURSED_TEMPLE
source\ZzzInterface.cpp:4435:#ifdef CSK_FIX_MACRO_MOVEMAP
source\ZzzInterface.cpp:8213:#ifdef LEM_FIX_USER_LOGOUT_SKILL_ENABLE
source\ZzzInventory.cpp:7787:#ifdef KJH_FIX_SELL_LUCKYITEM
source\ZzzInventory.cpp:7825:#ifdef KJH_FIX_PERSONALSHOP_BAN_CASHITEM
source\ZzzInventory.cpp:8038:#ifdef LEM_FIX_SELL_LUCKYITEM_BOOTS_POPUP
source\ZzzInventory.cpp:8163:#ifdef KJH_FIX_SELL_LUCKYITEM

I have not gone thru this one by one, I just grep'd them with the keyword "ifdef" and "FIX"