search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 115 forks source link

New Zealand regional holidays #108

Closed fkleon closed 4 years ago

fkleon commented 5 years ago

Hi

This PR adds most New Zealand regional holidays, except for Canterbury Anniversary.

Canterbury Anniversary is defined as the second Friday after the first Tuesday in November each year, which would require an extension of the existing RelativeToWeekdayInMonthParser for the which attribute, or a new FixedWeekdayRelativeToFixedWeekdayParser.

It would also be useful to implement a relative-to-holiday parser, that understands rules such as the Monday after Labour Day, where Labour Day might be defined by a non-trivial rule elsewhere.

This implementation is based on:

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.6%) to 63.975% when pulling ca2b73c122c2eda89707573917c05c0164902fbe on fkleon:feature-new-zealand-regional-holidays into 8ac5c185c8ef143ebc05f2f6ff8ef136d028eb81 on svendiedrichsen:master.