search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 115 forks source link

Adjusting Marine/Navy/Sea public holiday in Japan #133

Closed xHoang closed 4 years ago

xHoang commented 4 years ago

Currently the code for the marine day JPY holiday is put as June 20th. This is no longer the case and is instead on the third monday of July. How do I implement this functionality into https://github.com/svendiedrichsen/jollyday/blob/master/src/main/resources/holidays/Holidays_jp.xml

Thanks

svendiedrichsen commented 4 years ago

@xHoang You could probably do it like this: <tns:FixedWeekday which="THIRD" weekday="MONDAY" month="JULY" validFrom="2020" descriptionPropertiesKey="..."/> Don't forget to set the validUntil="2019" to the previously valid date.

svendiedrichsen commented 4 years ago

@xHoang According to Wikipedia the Marine/Navy Day was held from 1996 to 2002 on the 20 of July. From 2003 onwards it was held on the 3rd monday in july. The holidays file already reflects this. Please see: https://en.wikipedia.org/wiki/Public_holidays_in_Japan