search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
190 stars 114 forks source link

Missing entries in Swiss XML file #137

Closed CHTHSCH closed 4 years ago

CHTHSCH commented 4 years ago

Whit_Sunday, Whit_Monday and Easter_Monday are missing in the xml file for Switzerland.

https://github.com/svendiedrichsen/jollyday/blob/master/src/main/resources/holidays/Holidays_ch.xml

svendiedrichsen commented 4 years ago

For Whit Monday and Easter Monday: They are not holidays in the canton of Valais. So I have added them only to the relevant cantons.

For Whit Sunday there is actually no entry for this being a holiday in Wikipedia at all. Could you provide a source for this, please?

https://en.wikipedia.org/wiki/Public_holidays_in_Switzerland

The structure of the holiday data xml file is such that the holidays do add up from the general switzerland wide holidays to the more specific for each canton. So if you look at the list of holidays by only using Switzerland in general you will only get those holidays relevant for all of Switzerland.

CHTHSCH commented 4 years ago

Thanks for responding. My source is this: http://www.feiertage-schweiz.ch/

CHTHSCH commented 4 years ago

And the official: https://www.bj.admin.ch/dam/data/bj/publiservice/service/zivilprozessrecht/kant-feiertage.pdf

Sundays, like Easter Sunday, Whit Sunday not listed because they are off anyway.