search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 116 forks source link

Ever considered to add school vacations? #146

Open dusiema opened 3 years ago

dusiema commented 3 years ago

Hey @svendiedrichsen, Thank you for your work on this lib and open sourcing it.

Have you ever considered to add school vacations to this lib? Even if you don't want to do it would you be open to accept pull-requests to this? I am not saying I will do it right away - I was just curious. :-)

(Sorry if miss-used an issue to ask this question.)

grexe commented 3 years ago

on a related note, and to make this a full issue, so @dusiema need not worry:), 15. November is only a school holiday in Vienna, Austria, but not an official holiday: https://github.com/svendiedrichsen/jollyday/blob/master/src/main/resources/holidays/Holidays_at.xml#L66

dusiema commented 3 years ago

I wonder if jollyday is still alive?