search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 116 forks source link

Added election days to South African holidays. #147

Closed aholland closed 2 years ago

aholland commented 3 years ago

The main change was to data in Holidays_za.xml, adding election days. Also grouped all once-off holidays (including the newly added election days) into one section of the file. See https://en.wikipedia.org/wiki/Public_holidays_in_South_Africa for my source information on the election days.

If you are happy with your pom then you need not take the changes I made to pom.xml, which are as follows:

Changes to pom.xml: I then had some trouble using Maven to build and package Jollyday ("0.5.11-SNAPSHOT"). After getting the error "Failed to execute goal biz.aQute.bnd:bnd-maven-plugin:4.1.0:bnd-process (default) on project jollyday: bnd error: null" I did some reading about bnd, found a similar error on StackTrace where the respondent suggested 4.1.0 was old, and decided to try a newer version of bnd. By changing the bnd version to 5.2.0 (the latest) I made the error go away. Finally, I deliberately do not have JAVA_HOME set on my machine, so I specified the javadocExecutable for the maven-javadoc-plugin.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 64.292% when pulling f0769035289a63859bf796ad043bb9b9638d92ff on aholland:master into 1d527d95a8efbf26513709f45fe74fd5f2547265 on svendiedrichsen:master.