search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
190 stars 114 forks source link

New Year Observed holiday #173

Open karkeedaniel opened 1 year ago

karkeedaniel commented 1 year ago

I have the following configuration for New Year Holiday.

<tns:Fixed month="JANUARY" day="1" descriptionPropertiesKey="NEW_YEAR">
  <tns:MovingCondition substitute="SATURDAY" with="PREVIOUS" weekday="FRIDAY" />
  <tns:MovingCondition substitute="SUNDAY" with="NEXT" weekday="MONDAY" />
</tns:Fixed>

Since 01/01/2022 (New Year) is on Saturday the holiday observed should be on 12/31/2021 (Friday). The above configuration does not work.

I have tested the same configuration for Independence Day and it works as expected.

<tns:Fixed month="JULY" day="4" validFrom="1776" descriptionPropertiesKey="INDEPENDENCE">
  <tns:MovingCondition substitute="SATURDAY" with="PREVIOUS" weekday="FRIDAY" />
  <tns:MovingCondition substitute="SUNDAY" with="NEXT" weekday="MONDAY" />
</tns:Fixed>