svendiedrichsen / jollyday

Jollyday - A holiday API
Other
191 stars 114 forks source link

Germany: Reformationstag as one-time public holiday #32

Closed jschrod closed 8 years ago

jschrod commented 8 years ago

2017 we will have Reformationstag (2017-10-31) as public holiday in all of Germany, but only that year. I suppose one has to add a Fixed entry with validFrom and validTo at the top of Holidays_de.xml. Is this already in the works or do you want a pull request?

Cheers, Joachim

svendiedrichsen commented 8 years ago

Would be very nice of you if you could create a pull request for this. Thanks in advance. Cheers, Sven

GeBeater commented 8 years ago

Pull request #34 created.

jschrod commented 8 years ago

OK; a pull request within 16 minutes, while I'm watching semifinals; beats me. You're both obviously no football fans. :-) :-) Thanks a lot, Bernd and Sven!!

opensource21 commented 7 years ago

Any chance that a new version will be published? We now have 2017 and in 2018 the patch is useless.

svendiedrichsen commented 7 years ago

released 0.5.2 - but you don't have to wait for a release to have an updated calendar. simply have your own delivered with your app and use this.