search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
189 stars 114 forks source link

Fix relativetofixed parser #35

Closed christophse closed 8 years ago

christophse commented 8 years ago

The latest version of JollyDay has a bug concerning the RelativeToFixed rule.

All holidays with this relation (Repentance Prayer Day for Saxony/Germany and Victoria Day for Canada) are affected.

Example: Repentance Prayer Day in Saxony/Germany Rule: Wednesday before 2016-11-23 Result: 23st is a Wednesday so current output is 2016-11-23 Should be: 2016-11-16 (proper date)

Same case for Victoria Day on 2015-05-25. Output is 2015-05-25 but it should be 2015-05-18.

If there someday is a holiday which requires this function as currently implemented, we would propose a second rule RelativeToFixedInclusive or similar.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 88bcf48f402ea78a573fb5f7af6c0c5f6fd63385 on avantgarde-labs:fix_relativetofixed_parser into \ on svendiedrichsen:master**.

svendiedrichsen commented 8 years ago

Thanks very much.