search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
189 stars 114 forks source link

Fix: Use "Tag der Deutschen Einheit" for the unification day #45

Closed focbenz closed 7 years ago

focbenz commented 7 years ago

Use "Tag der Deutschen Einheit" for the unification day since 1990 including translations. Is it better to split the definition and create a new Holiday definition ?

The descriptionPropertiesKey="UNIFICATION" is also used in bg, lt and ro definitions.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 84.785% when pulling daba94ec8e243c8c05a763bf18fe9c23f4969cb5 on FOCONIS:fix/tag-der-deutschen-einheit into 97cc7ecea3b79a29a8411327871a7e6082a7a31e on svendiedrichsen:master.

svendiedrichsen commented 7 years ago

Yes, please split and use a new descriptionPropertiesKey="UNIFICATION_GERMANY". The translation "Tag der Deutschen Einheit" makes it specific for germany. Nevertheless translation for the other languages will be required as well. ;)

Thanx in advance. Cheers Sven

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 84.785% when pulling 600f6239245c0d6a7d37c5d99be2c38b8ee46420 on FOCONIS:fix/tag-der-deutschen-einheit into 97cc7ecea3b79a29a8411327871a7e6082a7a31e on svendiedrichsen:master.

focbenz commented 7 years ago

Split off into UNIFICATION_GERMANY and translations were already provided. Ready.