Add holidays for New Zealand

svendiedrichsen / jollyday

Jollyday - A holiday API

Other

189 stars 114 forks source link

Add holidays for New Zealand #60

Closed tenjaa closed 6 years ago

tenjaa commented 6 years ago

Hey,

I saw New Zealand was missing, so I added the statutory holidays as described in the law. Wikipedia summarizes them also pretty nice.

While writing this, I just saw that DAY_AFTER_NEW_YEAR and WAITANGI are unique, so I will add some translations for them.

And I copied from gb as you can see.. Will fix it too

Please tell me if I missend anything!

References: http://www.legislation.govt.nz/act/public/2003/0129/latest/DLM237120.html#DLM237120 https://en.wikipedia.org/wiki/Public_holidays_in_New_Zealand

coveralls commented 6 years ago

Coverage remained the same at 84.533% when pulling b78c3f69a10ba804e6fb125f3a5480532670ef41 on tenjaa:master into 3ee3df63d766f2db5bc0e11d87ef29081a01afb5 on svendiedrichsen:master.

coveralls commented 6 years ago

Coverage remained the same at 84.533% when pulling a51b8535539d2abf357ad7b9eb213c53858c25d2 on tenjaa:master into 3ee3df63d766f2db5bc0e11d87ef29081a01afb5 on svendiedrichsen:master.

tenjaa commented 6 years ago

Everything I saw should be fixed.

Waitangi Day is never translated if you look through Wikipedia or the rest of the internet. So I left it as it is in every language.

Would be cool to get some feedback :)

svendiedrichsen commented 6 years ago

@tenjaa As far as I can tell it looks very good. Thank you very much.

tenjaa commented 6 years ago

Cool! 👍

Do you have an idea when to release the next version and we can expect these changes on maven central?

svendiedrichsen commented 6 years ago

I had no plans but I will do it any day soon now.

svendiedrichsen commented 6 years ago

0.5.3 is released. Have fun.