svendiedrichsen / jollyday

Jollyday - A holiday API
Other
189 stars 114 forks source link

Missing holiday for german state hessen/hessia #75

Closed andy-d2019 closed 6 years ago

andy-d2019 commented 6 years ago

The easter-sunday should be counted as a holiday in the german states Brandenburg and Hessen, but jollyday only counts it for Brandenburg.

thackel commented 6 years ago

Interesting topic :-)

In wikipedia they wrote:

  • für Hessen kann keine sinnvolle Angabe gemacht werden, da alle Sonntage als gesetzliche Feiertage gelten

https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland#%C3%9Cbersicht_aller_gesetzlichen_Feiertage

svendiedrichsen commented 6 years ago

The official website of Hessias ministry of internal affairs and sports does not state easter sunday to be an official holiday: https://innen.hessen.de/buerger-staat/gesetzliche-feiertage

Please see the section Service on the right hand side for 2018.

On https://en.wikipedia.org/wiki/Public_holidays_in_Germany you can find:

In addition the state of Brandenburg has formally declared Easter Sunday and Pentecost Sunday as public holidays. As these are Sundays anyway, they have been left away by the other states, nor counted in the table above (the state of Hesse even declared all Sundays public holidays).

In my opinion the only sensible option would be to remove Easter Sunday and Pentecost from Brandenburg. WDYT?

andy-d2019 commented 6 years ago

Removing them from Brandenburg is imho not a sensible option, as they are still official holidays and thus valid information would be lost. E.g the use case im using jolliday for requires knowing when a holiday is irregardless of it being a sunday.

I was imho wrong in the case of easter sunday for hessia though after reading the sources you guys provided.

svendiedrichsen commented 6 years ago

@andy-d2019 This can be closed then?

andy-d2019 commented 6 years ago

Yes the issue is resolved then.

EDIT: I would say the 100% correct logic would be counting every sunday in hessia as a holiday, since the hessian holiday law says every sunday is a holiday.

svendiedrichsen commented 6 years ago

@andy-d2019 I wouldn't do that.