svendiedrichsen / jollyday

Jollyday - A holiday API
Other
189 stars 114 forks source link

Label Issues #80

Closed opensource21 closed 6 years ago

opensource21 commented 6 years ago

I make a test with german translation 3.10. must be "Tag der Deutschen Einheit" not "German Unity Day"

opensource21 commented 6 years ago

Weird: if I run the test

@Test
public void testManagerDETagDerDeutschenEinheit() {
    try {
        HolidayManager instance = HolidayManager.getInstance(HolidayCalendar.GERMANY);
        Set<Holiday> holidays = instance.getHolidays(LocalDate.of(2010, 10, 1), 
                LocalDate.of(2010, 10, 4));
        Assert.assertEquals("Wrong number of holidays", 1, holidays.size());
        for (Holiday d : holidays) {
            Assert.assertEquals("Tag der Deutschen Einheit", d.getDescription(Locale.GERMANY));
        }
    } catch (Exception e) {
        Assert.fail("Unexpected error occurred: " + e.getClass().getName() + " - " + e.getMessage());
    }
}

In my project it fails. If I check out the source code everything is fine :-/ Perhaps something with spring? Any suggestions are welcome.

opensource21 commented 6 years ago

A wrong properties-file was in my classpath, because I had made a quickfix in an older version. Sorry for the trouble.

svendiedrichsen commented 6 years ago

No problem.