search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 115 forks source link

Austrian holidays #84

Closed dwuehrer closed 5 years ago

dwuehrer commented 5 years ago

Hello,

this is a bit complicated.

The resource file for Austrian holidays https://github.com/svendiedrichsen/jollyday/blob/master/src/main/resources/holidays/Holidays_at.xml lists Christmas Eve (24 Dec) and New Years Eve (31 Dec) as official holidays.

However: https://www.arbeiterkammer.at/beratung/arbeitundrecht/Arbeitszeit/ArbeitszeitundRuhepausen/Feiertagsruhe.html#heading_Diese_Feiertage_stehen_allen_Beschaeftigten_zu

They are not official holidays. Although most collective labour agreements treat them as half a work day each.

I think that their HolidayType should return false for isOfficialHoliday().

Will you consider changing them?

svendiedrichsen commented 5 years ago

Sure. I'm actually not an expert on the holiday subject. Especially not when it comes to holidays abroad.

dwuehrer commented 5 years ago

Great! Thank you.

svendiedrichsen commented 5 years ago

Merged your PR. Thank you.