Added subconfigurations for Aland Islands in Finland

svendiedrichsen / jollyday

Jollyday - A holiday API

Other

190 stars 114 forks source link

Added subconfigurations for Aland Islands in Finland #86

Closed kattisA closed 5 years ago

kattisA commented 5 years ago

Aland islands in Finland have a self-governage day they highly appreciate. We have used this for my work and I think Aland will be grateful to have this change to the jollyday repository! Thank you, Greetings Katarina

svendiedrichsen commented 5 years ago

@kattisA Could you take care of the failing test please? And is there already a translation for SELF_GOVERNANCE? If not could you provide it please? Thank you.

kattisA commented 5 years ago

@svendiedrichsen In Aland islands in FInland the official language is Swedish therefore the translation is in Swedish, I don't know the Finnish name. I will probably be able to contribute more to your library for the Swedish properties file (where the rest of the holidays are in English for now) and maybe also add the Finnish name of the holiday.

svendiedrichsen commented 5 years ago

@kattisA That would be great. Merging and closing this PR. Feel free to open new PRs for any contributions. Thank you very much.

coveralls commented 5 years ago

Coverage increased (+0.2%) to 82.916% when pulling 9b9b479f01d04a411673199a60bfd41db4ac7306 on kattisA:Subconfigure-Aland-Islands-Finland into 8292d8bb3389e36e5ac77639e6f00ca88d5b0ec4 on svendiedrichsen:master.