search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 115 forks source link

chinese holidays #87

Open MenoData opened 5 years ago

MenoData commented 5 years ago

see https://github.com/svendiedrichsen/jollyday/issues/43

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 83.064% when pulling 570661e723d9fd4ddfe28aa5e332c1f4a30ab187 on MenoData:master into e359ee24729331fa08201353dbdc911de6e9924f on svendiedrichsen:master.

svendiedrichsen commented 5 years ago

Great work. Glad to include it. Just one minor request. Please see review.

MenoData commented 5 years ago

Hm, I have problems to see any review or minor request. Anyway, this PR will ensure to find the right days of official chinese holidays and those of Hongkong. What is not yet tackled are the complex compensation rules when ever a holiday falls on a weekend (see wikpedia), but this might be realized in another second step (you know better your API). And sometimes the government of China can suddenly change the compensation rules as happened several times in the past, so ultimate safety for any holiday dates is only given by official announcements in December.

maccamlcQ commented 4 years ago

I had a quick look at this PR, and trying to understand how the Chinese holidays are arranged. Would the intention for Chinese New Year, for example, be to list holiday as only the actual day, or try to find a way to cover the 7 day holiday from Eve to 6 days later?

I assume would need some additional constructs to calculate this type of requirement.