search

svendiedrichsen / jollyday

Jollyday - A holiday API
Other
186 stars 115 forks source link

Question about adding new countries. #93

Open ryan-cal opened 5 years ago

ryan-cal commented 5 years ago

There are a few countries I would like to contribute to this library. What is the process around that?

Ref: https://calendarific.com/holidays/2019/EG https://calendarific.com/holidays/2019/FJ https://calendarific.com/holidays/2019/MF

hakan42 commented 5 years ago

Hi,

you fork this repository, create a file similar to the ones in src/main/resources/holidays/, . for example https://github.com/svendiedrichsen/jollyday/blob/master/src/main/resources/holidays/Holidays_in.xml for India, and create a pull request to add it to the repository.

If you are not comfortable with git and branches and pull requests and so on, you can just write the XML file, attach it to the ticket here and someone (perhaps even me :) ) will help you getting it into the main distribution.

Regards, Hakan

hakan42 commented 5 years ago

Also, this reminds me, I alway wanted to add public holidays in Turkey to this list :)

https://calendarific.com/holidays/2019/TR

svendiedrichsen commented 5 years ago

@ryan-cal Please setup a pull request. We can work it out together then. You will find plenty of examples in the code.

svendiedrichsen commented 5 years ago

@hakan42 Please feel free to file a pull request too.

hakan42 commented 5 years ago

@hakan42 Please feel free to file a pull request too.

Just did so, https://github.com/svendiedrichsen/jollyday/pull/94

svendiedrichsen commented 5 years ago

@ryan-cal Pull request #94 is a good example on how to add a country.