search

svenevs / exhale

Automatic C++ library api documentation generation: breathe doxygen in and exhale it out.
BSD 3-Clause "New" or "Revised" License
222 stars 51 forks source link

fix current tests #219

Closed renefritze closed 3 months ago

renefritze commented 3 months ago

split off from https://github.com/svenevs/exhale/pull/218 with changes not relating to C++ concepts

svenevs commented 3 months ago

Thank you. Brief response between things. I'm clearing Saturday, let's get concepts in.

This has been approved to run CI. But if it takes you more than a few stabs I'll step in. CI has probably been broken here for a while...

renefritze commented 3 months ago

Closing this for now to do trial and error in my fork instead

renefritze commented 3 months ago

https://github.com/renefritze/exhale/pull/3

renefritze commented 3 months ago

The current tests now all pass in my fork. Couple of notes:

  1. I've moved to using the codecov action because the deprecated upload immeadiately ran into rate limiting.
  2. If you're not happy with the new lowest supported version, it's probably not too hard to fix the tests for it. The errors just looked like SPhinx internals that I knew nothing about.
  3. I've added a mostly unintrusive pre-commit setup, mostly to get actionlint going. Would you be happy with a more substantial config that also does linting and formatting (with ruff)?
  4. Locally the Fortran CPPFOrtranMixed.tests_hierarchies fails. For some reason the checked functions have an additional intent(in) argument. I've just ignored that.
renefritze commented 3 months ago

Looks like the PR doesn't update from the source branch. I'll try opening a new one instead.