search

svenfuchs / routing-filter

routing-filter wraps around the complex beast that the Rails routing system is, allowing for unseen flexibility and power in Rails URL recognition and generation.
http://www.artweb-design.de
MIT License
464 stars 84 forks source link

Fix issue with ActionDispatch::Routing::DeprecatedMapper #16

Closed parndt closed 13 years ago

parndt commented 13 years ago

This class is gone in edge rails, so we should only use it when it's present.

Thanks!

parndt commented 13 years ago

Any indication on whether this will be merged? Thanks :)

svenfuchs commented 13 years ago

applied: https://github.com/svenfuchs/routing-filter/commits/master/

Thanks a lot for the patch! And ... sorry for the long delay.

parndt commented 13 years ago

Sorry, you applied this? I don't see the commit in the history and the changes are not here: https://github.com/svenfuchs/routing-filter/blob/master/lib/routing_filter/adapters/rails_3.rb

svenfuchs commented 13 years ago

Wow, weird. I'm super sure I've applied it via fork queue. It doesn't show up in the fork queue anymore either.

Anyway. I've cherrypicked it once again: https://github.com/svenfuchs/routing-filter/commit/772b3dddf877f0150016b6c251d5d97b9c4e8156

parndt commented 13 years ago

Yeah, I'm sure I saw it apply momentarily too but then was puzzled that it was gone later on. Thanks, Sven, for all your hard work with i18n.