search

svenfuchs / routing-filter

routing-filter wraps around the complex beast that the Rails routing system is, allowing for unseen flexibility and power in Rails URL recognition and generation.
http://www.artweb-design.de
MIT License
464 stars 84 forks source link

Using 'tap' instead of 'returning' #25

Closed dce closed 13 years ago

dce commented 13 years ago

Hi guys,

We're using routing-filter on a Rails 2 app, and it's working very well. When we upgraded to 2.3.11, though, we started getting a bunch of warnings since routing-filter calls 'returning', which has been deprecated. This patch replaces the call with a call to 'tap'.

Thanks, David

kuroda commented 13 years ago

+1

rud commented 13 years ago

Another +1 from me - this sure is a noisy deprecation for Rails 2 apps. I get a lot of these:

DEPRECATION WARNING: Kernel#returning has been deprecated in favor of Object#tap. (called from dashboard_path at (eval):4)

The patch looks correct.

dce commented 13 years ago

We finally ended up just releasing our own gem: https://rubygems.org/gems/vigetlabs-routing-filter. Might be useful to you guys in the interim.

tomash commented 13 years ago

I'll contact Sven, apparently he hasn't visited github for some time now

sebbacon commented 13 years ago

+1, just started writing the patch myself

kuroda commented 13 years ago

I've got the collaborator status of this repository and pulled this.

As for a new gem, wait until I get the ownership of routing-filter gem.

kuroda commented 13 years ago

A new gem routing-filter 0.2.4 has been published.