search

svenfuchs / routing-filter

routing-filter wraps around the complex beast that the Rails routing system is, allowing for unseen flexibility and power in Rails URL recognition and generation.
http://www.artweb-design.de
MIT License
464 stars 84 forks source link

Now working on Rails 4 #43

Closed tricknotes closed 11 years ago

membLoper commented 11 years ago

+1

bikramwp commented 11 years ago

+1. When can this pull request be merged in?

kuroda commented 11 years ago

Merged.

With these commits, I see the test failures on Ruby 1.8.7 and Ruby 1.9.2. I'm working on this problem.

kuroda commented 11 years ago

I excluded tests on Rails 4.0 if RUBY_VERSION < 1.9.3. See dcaf7a74951bb7d2cdada5564315ca25245f1bbd.

tricknotes commented 11 years ago

I confirmed about tests. Thanks a lot :smile:

macovsky commented 11 years ago

Hey guys, I'm not sure what's working for you in Rails 4, but RoutingFilter::Locale is definitely not working for me on Rails 4 / ruby 2. The locale is being parsed from the URL, but it's not being prepended to generated URLs. Can you please check that it's working for you?