search

svenfuchs / routing-filter

routing-filter wraps around the complex beast that the Rails routing system is, allowing for unseen flexibility and power in Rails URL recognition and generation.
http://www.artweb-design.de
MIT License
464 stars 84 forks source link

request.path did not work any more #56

Closed gauda closed 9 years ago

gauda commented 9 years ago

request.path (which is used by current_url?) did not work any more (I think it's the same like in issue #7 again). Here is the fix. I hope the test is in the right place. Thank you for this awesome gem!

simi commented 9 years ago

Hello @gauda. Thanks for this patch. Can you provide me more informations? Why env can be Hash or Object? Are you using JRuby?

simi commented 9 years ago

Actually it makes sense since https://github.com/gauda/routing-filter/blob/844b87b0b0d53efc6c5547171c5265489424b143/lib/routing_filter/adapters/routers/journey.rb#L9 line.

Do you think https://github.com/svenfuchs/routing-filter/blob/14761c10b8b5d91fd563dadf6271cfc8fd02935e/lib/routing_filter/adapters/routers/rack_mount.rb#L25 should be fixed also?

gauda commented 9 years ago

Hi Josef,

good question :) I'm using:

$ ruby --version ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]

$ rails --version Rails 4.2.1

so that's quite default. When I revert my changes the test fails. I am not quite sure wha's the cause of that. Do you have a different result?

Regards,

On Fri, Jul 31, 2015 at 1:11 PM, Josef Šimánek notifications@github.com wrote:

Actually it makes sense since https://github.com/gauda/routing-filter/blob/master/lib/routing_filter/adapters/routers/journey.rb#L9 line.

Do you think https://github.com/svenfuchs/routing-filter/blob/14761c10b8b5d91fd563dadf6271cfc8fd02935e/lib/routing_filter/adapters/routers/rack_mount.rb#L25 should be fixed also?

— Reply to this email directly or view it on GitHub https://github.com/svenfuchs/routing-filter/pull/56#issuecomment-126656773 .