search

svenhb / GRBL-Plotter

A GCode sender (not only for lasers or plotters) for up to two GRBL controller. SVG, DXF, HPGL import. 6 axis DRO.
https://grbl-plotter.de/
GNU General Public License v3.0
647 stars 172 forks source link

Probe one axis issue. #339

Closed ScottEgan closed 1 year ago

ScottEgan commented 1 year ago

Describe the bug When probing just one axis using the "Probe one axis, extrude other" function, Scanning along the X axis works fine, and the X dimension increments after each probe. Unfortunately scanning along the Y-axis doesn't work and the tool just stays in one position. This can be seen in the output tab gcode as well. Also in English, I think this function should say "Probe one axis, exclude other" rather than extrude.

To Reproduce Steps to reproduce the behavior:

  1. Go to Workpiece > Surface Scan / Height Map
  2. Click on the "Area to scan" tab
  3. Select the "Probe one axis, extrude other" check box
  4. Select the "Scan Y, extrude X" radio box
  5. Click "Generate Height Map" at bottom of screen
  6. Click the "Output" tab and review the gcode

Expected behavior When scanning along X you can see in the gcode that after each probe command Z will move back up and the X position will increment. This does not happen when scanning along the Y axis.

Scan X gcode snip:

(Probing Size X:36 Y:26 )ExtrudeY scan X axis, extrude in Y
Code sent
G90F600
G0Z2
G0Y0
G0Z2
G0X0
G38.3Z-5
G0Z2
G0X20
G38.3Z-5
G0Z2
G0X40
G38.3Z-5
G0Z2
G0X60
G38.3Z-5
G0Z2
G0X80
G38.3Z-5
G0Z2
G0X100

Scan Y gcode snip:

(Probing Size X:36 Y:26 )ExtrudeX scan Y axis, extrude in X
Code sent
G90F600
G0Z2
G0X0
G0Z2
G0X0
G38.3Z-5
G0Z2
G0X0
G38.3Z-5
G0Z2
G0X0
G38.3Z-5
G0Z2
G0X0
G38.3Z-5
G0Z2
G0X0

Screenshots Correct behavior on Scan X image

Incorrect behavior on Scan Y image image

svenhb commented 1 year ago

Thanks for the feedback. I made a mistake during code-simplification and forgot to seperate the X and Y axis. About naming this function: I thought about CAD, generating a 3D model from a 2D scetch -> extrude. Here, 2D data is generated from a 1D scan.

ScottEgan commented 1 year ago

Thank you for the quick response!

About naming this function: I thought about CAD, generating a 3D model from a 2D sketch -> extrude. Here, 2D data is generated from a 1D scan.

Ahh ok. I didn't think about it that way but it makes sense now. Thank you for explaining.

svenhb commented 1 year ago

You may try this bug fix version: https://github.com/svenhb/GRBL-Plotter/blob/master/GRBL-Plotter_Setup.exe Closing this issue happend automatically after uploading the setup.exe...

ScottEgan commented 1 year ago

Seems to still behave the same. image

svenhb commented 1 year ago

Ok, thanks for testing. I thought I found the mistake as it was so obvious, without testing...

ScottEgan commented 1 year ago

No worries, I don't mind running the tests!

svenhb commented 1 year ago

Now it is fixed: https://github.com/svenhb/GRBL-Plotter/blob/master/GRBL-Plotter_Setup.exe Not just the axis name is important, also the axis value must be switched :-)

ScottEgan commented 1 year ago

Sorry for the late reply, I finally got around to testing. Works as expected now! Thank you! We can close

image

svenhb commented 1 year ago

Thanks for the feedback.