svenhb / GRBL-Plotter

A GCode sender (not only for lasers or plotters) for up to two GRBL controller. SVG, DXF, HPGL import. 6 axis DRO.
https://grbl-plotter.de/
GNU General Public License v3.0
669 stars 177 forks source link

When saving gcode, non-gcode lines appear #369

Closed lfmmd closed 8 months ago

lfmmd commented 9 months ago

Describe the bug When saving gcode, non-gcode lines appear

To Reproduce Steps to reproduce the behavior: 1.run

  1. file
  2. openfile
  3. select dxf file
  4. Directly close the parameter prompt window that appears
  5. ctrl + s save .nc file

Expected behavior Under normal circumstances, it should output clean gcode code without appearing like <Collection"> file.zip The situation is different without actively closing the parameter prompt window. I have included in the file what I think is necessary, if anything else is needed please let me know

lfmmd commented 9 months ago

The problem occurred when I upgraded from 1.6.9.4 to 1.7.1.0

svenhb commented 9 months ago

I assume you used this options? image image

I can't find a bug. Could you repoduce with 1.7.1.0? Perhaps you modified the G-code manually before saving?

lfmmd commented 9 months ago

image I couldn't find it “remove all comments when saveing” Can you provide the path for setting up

lfmmd commented 9 months ago

image I retested and found that after actively closing this window, the gcode still showed contamination

svenhb commented 9 months ago

Can you upload the original DXF file and the resulting G-Code, without this option to remove comments? image

lfmmd commented 9 months ago

dxfandfile.zip I'm really sorry, the file I uploaded last time did not include dxf.

lfmmd commented 9 months ago

您能否上传原始 DXF 文件和生成的 G 代码,而不使用此选项来删除注释? 图像

I didn't find this option on the software

svenhb commented 9 months ago

image

svenhb commented 9 months ago

Also if I import your DXF file and save it with "Remove all commands" and load the saved gcode file, there is no problem.