svenhjol / Strange

Charm, but Stranger
17 stars 6 forks source link

Strange 1.15.2 is causing Respawnable Pets mod to not function correctly #89

Closed Nick-McKay closed 3 years ago

Nick-McKay commented 4 years ago

Describe the bug (required) Strange causes the mod Respawnable Pets to function incorrectly likely due to calling "attackEntityFrom" after punching and thus duplicating punches. There was a similar issue in ToughAsNails https://github.com/Glitchfiend/ToughAsNails/blob/40e5aa7e993c6f1fa3c3107491e45fbd1934d802/src/main/java/toughasnails/handler/thirst/ThirstStatHandler.java#L95

Versions (required)

Additional context (optional) This issue only occurs when Strange is installed and not when just Charm is installed. The desired result is one in which Respawnable pets allows you to toggle your pets' ability to respawn by left-clicking them with the Etheric Gem. A dialog should show up on screen indicating that the function was toggled.