svenjacobs / chipcaco

Node.js command line tool and library for converting .264 files produced by some Chinese IP cameras
MIT License
11 stars 7 forks source link

Keeping audio content would be nice #1

Open function1983 opened 5 years ago

function1983 commented 5 years ago

Hi @svenjacobs ,

Thank you so much for the implementation. It's sad that the source page is now 404. Luckily we still have a web snapshot of the content. https://web.archive.org/web/20180302014739/https://www.spitzner.org/kkmoon.html

My concern though, it the time it takes to convert a 30MB (dot)264 file. My simple table.

============== YOUR CODE ====== SOURCE GCC =====
PC        |      <1 sec     |       <1 sec      |
================================================
Android   |     ~30mins     |       2 secs      |
================================================

The Android device (4 core S905w) runs your code in only one core with 100% CPU usage, the other 3 cores sit and do nothing) The same Android device though have no problem running on all core at decent speed.

I find it to be very weird.

And also, as the title suggest, it would be nice if you can also output a wav file along with the video like the original author did.

Best.

svenjacobs commented 5 years ago

Hi @function1983,

regarding that extremely long runtime on Android that's really weird. The code uses Promises so everything should scale nicely. Due you mind telling me how you run the NodeJS application on Android? Maybe it's an issue of the runtime environment? I didn't even know up to now that running NodeJS on Android is possible 😅

Regarding audio output I'm currently quite busy but feel free to create a pull request. Porting this part of the C application should be relatively straightforward.

bombcheck commented 3 years ago

Would love to see the audio being kept as well. Can anybody give me the compiled C-Program?