search

svenjacobs / leon

Android app for removing tracking parameters from shared URLs
GNU General Public License v3.0
234 stars 17 forks source link

CMP query string in The Guardian links #151

Closed codeinabox closed 1 year ago

codeinabox commented 1 year ago

Firstly thank you for such a great useful open source tool! I have a question, I tried sanitising the following link from The Guardian and the link was unchanged

https://www.theguardian.com/world/2023/jan/15/nepal-plane-crash-with-72-onboard-leaves-at-least-16-dead?CMP=Share_AndroidApp_Other

Should the CMP query string, which indicates how the link was shared, be removed or is that outside the scope of this tool? If It should be removed, I am happy to raise a PR for a new sanitiser

svenjacobs commented 1 year ago

Hello @codeinabox,

thanks for your feedback. Any parameters that are not relevant for the proper functionality of the site should be removed. So I would be happy about a pull request 😃

svenjacobs commented 1 year ago

Hello @codeinabox,

do you still want to provide a PR? 😃

codeinabox commented 1 year ago

I don't think I'll have time to do this, so I'm going to close this issue

svenjacobs commented 1 year ago

I reopen the issue. Maybe we will find someone else who is willing to implement it 😃

svenjacobs commented 1 year ago

This has been added and will be available in the next release 😃

svenjacobs commented 1 year ago

@all-contributors please add @codeinabox for ideas

allcontributors[bot] commented 1 year ago

@svenjacobs

I've put up a pull request to add @codeinabox! :tada: