svenjacobs / leon

Android app for removing tracking parameters from shared URLs
GNU General Public License v3.0
227 stars 16 forks source link

Default decode and extract options #200

Closed BrajBliss closed 9 months ago

BrajBliss commented 1 year ago

An option to enable these before importing an URL so we don't have to always turn these options on or off.

svenjacobs commented 1 year ago

Hello @vrindavan,

do you have an example of a URL that always needs to be decoded? Of course what I could do is remember the states of these toggles.

BrajBliss commented 1 year ago

I was referring to all URLs in general. You can consider the Spotify or Threads URL for instance (previous issues). An option to remember states would be better.

I use Twitter and Spotify URLs mostly.

Another threads URL if you need: - https://www.threads.net/t/Cugs0gYJcaH/?igshid=NTc4MTIwNjQ2YQ==

svenjacobs commented 1 year ago

Just to be clear: The "decode" toggle means to decode an URL which was URL encoded. See #49 why this was added. Usually this option is not required.

BrajBliss commented 1 year ago

Sure. I was talking about extract only.

serrq commented 1 year ago

Also my RSS reader breaks the ***** with article title + url (merged).

svenjacobs commented 1 year ago

Also my RSS reader breaks the ***** with article title + url (merged).

Sorry I don't understand. How is this related to the decode and extract toggles?

serrq commented 1 year ago

Also my RSS reader breaks the ***** with article title + url (merged).

Sorry I don't understand. How is this related to the decode and extract toggles?

I allude to the extraction of the url. Sometimes it happens that my RSS reader sends in the function "share" title and url together.

Did I misunderstand you?

serrq commented 1 year ago

Of course the share function send the result to the default browser (Leon). Understand?

svenjacobs commented 1 year ago

Could you please provide an example of the text that your RSS shares and what Leon does with it. When you use "extract", does it not work as expected?

serrq commented 1 year ago

Give me a minute. It works fantastically, but with manual action, not by default.

I have to turn switch ON manually. Not a problem!

serrq commented 1 year ago

Japan, Canada to develop North American EV battery supply chains https://asia.nikkei.com/Spotlight/Supply-Chain/Japan-Canada-to-develop-North-American-EV-battery-supply-chains2

1000040438

myuseraccount commented 9 months ago

So, is it supposed to remember the toggle I selected for "Extract only URL" the last time I shared a URL to the app? Because I just did the following:

  1. sent link from email to URL cleaner using share function
  2. toggled "extract only URL" to on
  3. sent a second link, from browser, using share to URL cleaner
  4. "extract only URL" was observed to be toggled off
svenjacobs commented 9 months ago

@myuseraccount This issue is about remembering the toggle states, that's correct. Unfortunately it has not been implemented yet.

svenjacobs commented 9 months ago

This has been resolved and will be available in the next release.

myuseraccount commented 9 months ago

Thank you! The app works great, this will just make it slightly fewer steps to get the result I want.