Correct composite builds

svenjacobs / reveal

Reveal effect (coach mark) for Compose Multiplatform targeting Android, iOS, Desktop and Web

MIT License

449 stars 8 forks source link

Correct composite builds #143

Closed Goooler closed 3 months ago

Goooler commented 3 months ago

After this, it could be run from the root project.
AGP versions used by demo-app and the root project should be kept the same.
includeBuild phrases should be placed in pluginManagement block.

svenjacobs commented 3 months ago

@Goooler Thanks for the pull request. Would it be possible now to specify the Reveal dependencies in demo-app via project references and not use the artifacts from Maven Central?

Goooler commented 3 months ago

We have to move demo-app out as a normal subproject instead of a standalone root project, or there will be a circular dependency issue in reverse.

svenjacobs commented 3 months ago

In commit afe6b08ec7052ac4f30bf8e98b0be56a807d6899 I moved the demo app to a separate project. It was a subproject before. There was some reason why I did it but I don't remember. Maybe it was a build issue because of Kotlin Multiplatform, maybe it had something to do with the publication of the library. I don't know.

Goooler commented 3 months ago

Or we can let demo-app include build reveal-root, shared module now depends on core and shapes.

svenjacobs commented 3 months ago

Or we can let demo-app include build reveal-root, shared module now depends on core and shapes.

I think I like that better. But instead of the substitutes, couldn't we directly use project(":reveal:core") etc?

Goooler commented 3 months ago

I'm not sure how to depend on composite build subprojects instead of module notations.